[PassKit] Added support for Xcode 10 up to beta 3.#4423
Merged
dalexsoto merged 2 commits intodotnet:xcode10from Jul 14, 2018
Merged
[PassKit] Added support for Xcode 10 up to beta 3.#4423dalexsoto merged 2 commits intodotnet:xcode10from
dalexsoto merged 2 commits intodotnet:xcode10from
Conversation
Collaborator
|
Build success |
dalexsoto
approved these changes
Jul 10, 2018
Member
dalexsoto
left a comment
dalexsoto
left a comment
There was a problem hiding this comment.
Minor things, really up to you if you want to change them
src/PassKit/PKEnums.cs
Outdated
| public enum PKAddPaymentPassStyle : ulong | ||
| { | ||
| Payment, | ||
| Access |
src/PassKit/PKEnums.cs
Outdated
| [NoWatch] | ||
| [Native] | ||
| public enum PKAddPaymentPassStyle : ulong | ||
| { |
Member
There was a problem hiding this comment.
Style, this should go one line up
Contributor
Author
|
@dalexsoto will fix those minor and will merge |
chamons
approved these changes
Jul 10, 2018
Collaborator
|
Build success |
spouliot
reviewed
Jul 23, 2018
| [Export ("requiresFelicaSecureElement")] | ||
| bool RequiresFelicaSecureElement { get; set; } | ||
|
|
||
| [iOS (12, 0)] |
Contributor
There was a problem hiding this comment.
missing [NoWatch] here - the enum type has the attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.